Skip to content

Conversation

@eeshm
Copy link
Contributor

@eeshm eeshm commented Jan 16, 2026

What does this PR do?

Fixes inconsistent disabled state for booking actions. Several actions (Edit location , Add Guests, Reroute, Reassign) were hardcoded to disabled: false, allowing users to see enabled buttons on cancelled, rejected, or past bookings.

Users could see enabled "Edit Location" or "Add Guests" buttons on bookings that were already cancelled/rejected/past, which doesn't make sense functionally.

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Changes -

  • change_location, add_members, reroute, reassign now use isActionDisabled() instead of hardcoded disabled: false
  • cancel action now properly checks for isCancelled and isRejected states
  • reschedule and reschedule_request now checks for isCancelled and isRejected states

Visual Demo (For contributors especially)

Video Demo (if applicable):

  • before:
cursorful-video-1768558098829.mp4
  • after:
cursorful-video-1768557741853.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Tested locally and verified with before/after screen recordings.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 16, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@anikdhabal anikdhabal added the Low priority Created by Linear-GitHub Sync label Jan 16, 2026
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add automated tests to verify this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync Low priority Created by Linear-GitHub Sync size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants